[PATCH v13 6/6] powerpc: add crash memory hotplug support
kernel test robot
lkp at intel.com
Tue Dec 5 08:48:40 PST 2023
Hi Sourabh,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/x86/core akpm-mm/mm-everything linus/master v6.7-rc4 next-20231205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sourabh-Jain/crash-make-CPU-and-Memory-hotplug-support-reporting-flexible/20231204-143305
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20231204053253.25305-7-sourabhjain%40linux.ibm.com
patch subject: [PATCH v13 6/6] powerpc: add crash memory hotplug support
config: powerpc64-randconfig-001-20231205 (https://download.01.org/0day-ci/archive/20231206/202312060059.JITEJl8B-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060059.JITEJl8B-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060059.JITEJl8B-lkp@intel.com/
All errors (new ones prefixed by >>):
arch/powerpc/kexec/core_64.c: In function 'arch_crash_get_elfcorehdr_size':
>> arch/powerpc/kexec/core_64.c:595:33: error: implicit declaration of function 'memory_hotplug_max' [-Werror=implicit-function-declaration]
595 | elf_phdr_cnt += memory_hotplug_max() / (2 * drmem_lmb_size());
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/memory_hotplug_max +595 arch/powerpc/kexec/core_64.c
579
580 /*
581 * Advertise preferred elfcorehdr size to userspace via
582 * /sys/kernel/crash_elfcorehdr_size sysfs interface.
583 */
584 unsigned int arch_crash_get_elfcorehdr_size(void)
585 {
586 unsigned int sz;
587 unsigned long elf_phdr_cnt;
588
589 /* Program header for CPU notes and vmcoreinfo */
590 elf_phdr_cnt = 2;
591 if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG))
592 /* In the worst case, a Phdr is needed for every other LMB to be
593 * represented as an individual crash range.
594 */
> 595 elf_phdr_cnt += memory_hotplug_max() / (2 * drmem_lmb_size());
596
597 /* Do not cross the max limit */
598 if (elf_phdr_cnt > PN_XNUM)
599 elf_phdr_cnt = PN_XNUM;
600
601 sz = sizeof(struct elfhdr) + (elf_phdr_cnt * sizeof(Elf64_Phdr));
602 return sz;
603 }
604
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the kexec
mailing list