[PATCH V3 07/11] notifiers: Add tracepoints to the notifiers infrastructure

Guilherme G. Piccoli gpiccoli at igalia.com
Sun Sep 18 07:07:12 PDT 2022


On 19/08/2022 19:17, Guilherme G. Piccoli wrote:
> Currently there is no way to show the callback names for registered,
> unregistered or executed notifiers. This is very useful for debug
> purposes, hence add this functionality here in the form of notifiers'
> tracepoints, one per operation.
> 
> Cc: Arjan van de Ven <arjan at linux.intel.com>
> Cc: Cong Wang <xiyou.wangcong at gmail.com>
> Cc: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Cc: Steven Rostedt <rostedt at goodmis.org>
> Cc: Valentin Schneider <valentin.schneider at arm.com>
> Cc: Xiaoming Ni <nixiaoming at huawei.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli at igalia.com>
> 
> ---
> 
> V3:
> - Yet another major change - thanks to Arjan's great suggestion,
> refactored the code to make use of tracepoints instead of guarding
> the output with a Kconfig debug setting.
> 
> V2:
> - Major improvement thanks to the great idea from Xiaoming - changed
> all the ksym wheel reinvention to printk %ps modifier;
> 
> - Instead of ifdefs, using IS_ENABLED() - thanks Steven.
> 
> - Removed an unlikely() hint on debug path.
> 
> [...]

Hi Arjan / Xioming, apologies for the ping.
Do you think the patch is good enough now? I liked the tracepoint
approach, indeed it was a much better idea than guarding the prints with
the DEBUG Kconfig heheh

Appreciate your opinions!
Thanks in advance,


Guilherme



More information about the kexec mailing list