[PATCH] ppc64: remove rma_top limit

Hari Bathini hbathini at linux.ibm.com
Fri Sep 16 03:58:03 PDT 2022



On 15/09/22 2:12 pm, Sourabh Jain wrote:
> Restricting kexec tool to allocate hole for kexec segments below 768MB
> may not be relavent now since first memory block size can be 1024MB and
> more.
> 
> Removing rma_top restriction will give more space to find holes for
> kexec segments and existing in-place checks make sure that kexec segment
> allocation doesn't cross the first memory block because every kexec segment
> has to be within first memory block for kdump kernel to boot properly.
> 
> Signed-off-by: Sourabh Jain <sourabhjain at linux.ibm.com>

Yeah. The restriction seems arbitrary. Even more so since commit
47478ea66d43 ("kexec-tools: ppc64: fix how RMA top is deduced")
with which kexec_load was sure to place all segments within the
first memory block. So, the change looks good to me.

Acked-by: Hari Bathini <hbathini at linux.ibm.com>

> ---
>   kexec/arch/ppc64/kexec-ppc64.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
> index 5b17740..611809f 100644
> --- a/kexec/arch/ppc64/kexec-ppc64.c
> +++ b/kexec/arch/ppc64/kexec-ppc64.c
> @@ -717,8 +717,6 @@ static int get_devtree_details(unsigned long kexec_flags)
>   			if (base < rma_base) {
>   				rma_base = base;
>   				rma_top = base + be64_to_cpu(((uint64_t *)buf)[1]);
> -				if (rma_top > 0x30000000UL)
> -					rma_top = 0x30000000UL;
>   			}
> 
>   			fclose(file);



More information about the kexec mailing list