[PATCH V3 08/11] EDAC/altera: Skip the panic notifier if kdump is loaded
Guilherme G. Piccoli
gpiccoli at igalia.com
Tue Nov 22 05:33:12 PST 2022
On 18/09/2022 11:10, Guilherme G. Piccoli wrote:
> On 19/08/2022 19:17, Guilherme G. Piccoli wrote:
>> The altera_edac panic notifier performs some data collection with
>> regards errors detected; such code relies in the regmap layer to
>> perform reads/writes, so the code is abstracted and there is some
>> risk level to execute that, since the panic path runs in atomic
>> context, with interrupts/preemption and secondary CPUs disabled.
>>
>> Users want the information collected in this panic notifier though,
>> so in order to balance the risk/benefit, let's skip the altera panic
>> notifier if kdump is loaded. While at it, remove a useless header
>> and encompass a macro inside the sole ifdef block it is used.
>>
>> Cc: Borislav Petkov <bp at alien8.de>
>> Cc: Petr Mladek <pmladek at suse.com>
>> Cc: Tony Luck <tony.luck at intel.com>
>> Acked-by: Dinh Nguyen <dinguyen at kernel.org>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli at igalia.com>
>>
>> ---
>>
>> V3:
>> - added the ack tag from Dinh - thanks!
>> - had a good discussion with Boris about that in V2 [0],
>> hopefully we can continue and reach a consensus in this V3.
>> [0] https://lore.kernel.org/lkml/46137c67-25b4-6657-33b7-cffdc7afc0d7@igalia.com/
>>
>> V2:
>> - new patch, based on the discussion in [1].
>> [1] https://lore.kernel.org/lkml/62a63fc2-346f-f375-043a-fa21385279df@igalia.com/
>>
>> [...]
>
> Hi Dinh, Tony, Boris - sorry for the ping.
>
> Appreciate reviews on this one - Dinh already ACKed the patch but Boris
> raised some points in the past version [0], so any opinions or
> discussions are welcome!
Hi folks, monthly ping heheh
Apologies for the re-pings, please let me know if there is anything
required to move on this patch.
Cheers,
Guilherme
P.S. I've been trimming the huge CC list in the series, done it here as
well.
More information about the kexec
mailing list