[PATCH] crash_dump: fix boolreturn.cocci warning
Baoquan He
bhe at redhat.com
Fri Oct 29 02:31:07 PDT 2021
On 10/20/21 at 08:39am, cgel.zte at gmail.com wrote:
> From: Changcheng Deng <deng.changcheng at zte.com.cn>
>
> ./include/linux/crash_dump.h: 119: 50-51: WARNING: return of 0/1 in
> function 'is_kdump_kernel' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng at zte.com.cn>
Looks good to me, thanks.
Acked-by: Baoquan He <bhe at redhat.com>
> ---
> include/linux/crash_dump.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..979c26176c1d 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -116,7 +116,7 @@ extern void register_vmcore_cb(struct vmcore_cb *cb);
> extern void unregister_vmcore_cb(struct vmcore_cb *cb);
>
> #else /* !CONFIG_CRASH_DUMP */
> -static inline bool is_kdump_kernel(void) { return 0; }
> +static inline bool is_kdump_kernel(void) { return false; }
> #endif /* CONFIG_CRASH_DUMP */
>
> /* Device Dump information to be filled by drivers */
> --
> 2.25.1
>
More information about the kexec
mailing list