On Mon, Dec 13, 2021 at 12:06:35AM +0000, Matthew Wilcox (Oracle) wrote: > + /* trim iter to not go beyond EOF */ > + if (iter->count > vmcore_size - *fpos) > + iter->count = vmcore_size - *fpos; Nit: iov_iter_truncate() Otherwise this looks good from a cursory view.