[PATCH linux-next] include:crash_dump: fix boolreturn.cocci warnings
Dave Young
dyoung at redhat.com
Thu Aug 26 20:08:29 PDT 2021
On 08/23/21 at 11:01pm, CGEL wrote:
> From: Jing Yangyang <jing.yangyang at zte.com.cn>
>
> ./include/linux/crash_dump.h:98:50-51:WARNING: return of 0/1 in
> function 'is_kdump_kernel' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang at zte.com.cn>
> ---
> include/linux/crash_dump.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b7..f92ebfe 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -95,7 +95,7 @@ static inline void vmcore_unusable(void)
> extern void unregister_oldmem_pfn_is_ram(void);
>
> #else /* !CONFIG_CRASH_DUMP */
> -static inline bool is_kdump_kernel(void) { return 0; }
> +static inline bool is_kdump_kernel(void) { return false; }
> #endif /* CONFIG_CRASH_DUMP */
>
> /* Device Dump information to be filled by drivers */
> --
> 1.8.3.1
>
>
Acked-by: Dave Young <dyoung at redhat.com>
Thanks
Dave
More information about the kexec
mailing list