[PATCH 1/3] Cleanup: Remove a superfluous seek to physical address 0
Petr Tesarik
ptesarik at suse.com
Wed Oct 7 02:56:50 EDT 2020
The file position is updated for each page in readmem() via a
read_pfn(). There is no point in seeking to PFN 0 data first.
Signed-off-by: Petr Tesarik <ptesarik at suse.com>
---
makedumpfile.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/makedumpfile.c b/makedumpfile.c
index 4c4251e..cdde040 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -8385,7 +8385,6 @@ write_kdump_pages_cyclic(struct cache_data *cd_header, struct cache_data *cd_pag
unsigned char buf[info->page_size], *buf_out = NULL;
unsigned long len_buf_out;
struct timespec ts_start;
- const off_t failed = (off_t)-1;
int ret = FALSE;
z_stream z_stream, *stream = NULL;
#ifdef USELZO
@@ -8422,16 +8421,6 @@ write_kdump_pages_cyclic(struct cache_data *cd_header, struct cache_data *cd_pag
per = info->num_dumpable / 10000;
per = per ? per : 1;
- /*
- * Set a fileoffset of Physical Address 0x0.
- */
- if (lseek(info->fd_memory, get_offset_pt_load_memory(), SEEK_SET)
- == failed) {
- ERRMSG("Can't seek the dump memory(%s). %s\n",
- info->name_memory, strerror(errno));
- goto out;
- }
-
start_pfn = cycle->start_pfn;
end_pfn = cycle->end_pfn;
--
2.26.2
More information about the kexec
mailing list