[PATCH] x86/boot: Call get_rsdp_addr() after console_init()

Baoquan He bhe at redhat.com
Tue May 21 02:28:08 PDT 2019


On 05/17/19 at 03:50pm, Borislav Petkov wrote:
> And now as a proper patch:
> 
> ---
> From: Borislav Petkov <bp at suse.de>
> 
> ... so that early debugging output from the RSDP parsing code can be
> visible and collected.
> 
> Suggested-by: Dave Young <dyoung at redhat.com>
> Signed-off-by: Borislav Petkov <bp at suse.de>
> Cc: Baoquan He <bhe at redhat.com>
> Cc: Chao Fan <fanc.fnst at cn.fujitsu.com>
> Cc: Jun'ichi Nomura <j-nomura at ce.jp.nec.com>
> Cc: Kairui Song <kasong at redhat.com>
> Cc: kexec at lists.infradead.org
> Cc: x86 at kernel.org
> ---
>  arch/x86/boot/compressed/misc.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
> index c0d6c560df69..24e65a0f756d 100644
> --- a/arch/x86/boot/compressed/misc.c
> +++ b/arch/x86/boot/compressed/misc.c
> @@ -351,9 +351,6 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
>  	/* Clear flags intended for solely in-kernel use. */
>  	boot_params->hdr.loadflags &= ~KASLR_FLAG;
>  
> -	/* Save RSDP address for later use. */
> -	boot_params->acpi_rsdp_addr = get_rsdp_addr();
> -
>  	sanitize_boot_params(boot_params);
>  
>  	if (boot_params->screen_info.orig_video_mode == 7) {
> @@ -368,6 +365,14 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
>  	cols = boot_params->screen_info.orig_video_cols;
>  
>  	console_init();
> +
> +	/*
> +	 * Save RSDP address for later use. Have this after console_init()
> +	 * so that early debugging output from the RSDP parsing code can be
> +	 * collected.
> +	 */
> +	boot_params->acpi_rsdp_addr = get_rsdp_addr();
> +
>  	debug_putstr("early console in extract_kernel\n");

Thanks for making this. FWIW,

Reviewed-by: Baoquan He <bhe at redhat.com>



More information about the kexec mailing list