[PATCH v4 2/2] kexec-arm64: Add functionality to dump 2nd dtb

Bhupesh Sharma bhsharma at redhat.com
Sat Jun 30 13:34:34 PDT 2018


Hi Simon and Akashi,

Sorry for the delay, I was out of office most of last week.

On 06/28/2018 05:06 AM, AKASHI Takahiro wrote:
> On Wed, Jun 27, 2018 at 02:04:38PM +0200, Simon Horman wrote:
>> On Thu, Jun 21, 2018 at 03:54:38PM +0530, Bhupesh Sharma wrote:
>>> Since during the arm64 kexec_load()/kdump invocation,
>>> the dtb is passed to the second kernel, it is sometimes useful
>>> to dump the dtb contents (to verify the correctness
>>> of the same).
>>>
>>> This patch adds this feature which is enabled when '-d' flag is
>>> used with kexec command line invocation.
>>
>> This seems significantly more verbose than what -d already outputs.
>> Perhaps a second debug level is warranted here?
> 
> +1
> Debug messages on arm64 are already noisy due to ones from
> machine_apply_elf_rel(), which are not very useful in most cases,
> even making logs hard to understand.
> Some sort of level be helpful here, too.

Ok, will work on the same and send out a v5 with the fixes.

Thanks,
Bhupesh

>>
>>>
>>> Signed-off-by: Bhupesh Sharma <bhsharma at redhat.com>
>>> ---
>>>   kexec/arch/arm64/kexec-arm64.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/kexec/arch/arm64/kexec-arm64.c b/kexec/arch/arm64/kexec-arm64.c
>>> index a206c172b1aa..47df756bd595 100644
>>> --- a/kexec/arch/arm64/kexec-arm64.c
>>> +++ b/kexec/arch/arm64/kexec-arm64.c
>>> @@ -540,6 +540,8 @@ static int setup_2nd_dtb(struct dtb *dtb, char *command_line, int on_crash)
>>>   	dtb->buf = new_buf;
>>>   	dtb->size = fdt_totalsize(new_buf);
>>>   
>>> +	dbgprintf("%s: found %s\n", __func__, dtb->path);
>>> +	dump_fdt(dtb->buf);
>>>   	dump_reservemap(dtb);
>>>   
>>>   	return result;
>>> -- 
>>> 2.7.4
>>>




More information about the kexec mailing list