[PATCH 10/11] kexec_file: Allow archs to set purgatory load address

kbuild test robot lkp at intel.com
Wed Feb 28 08:02:47 PST 2018

Hi Philipp,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.16-rc3 next-20180228]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Philipp-Rudo/kexec_file-Clean-up-purgatory-load/20180228-223538
config: i386-randconfig-a0-201808 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/crash_dump.h:5:0,
                    from drivers/scsi/aacraid/commsup.c:36:
>> include/linux/kexec.h:237:62: warning: 'struct kexec_buf' declared inside parameter list
    extern int kexec_load_purgatory(struct kimage *image, struct kexec_buf *kbuf);
   include/linux/kexec.h:237:62: warning: its scope is only this definition or declaration, which is probably not what you want
   include/linux/kexec.h:291:10: warning: 'struct purgatory_info' declared inside parameter list
             const Elf_Shdr *symtab);
   include/linux/kexec.h:295:6: warning: 'struct purgatory_info' declared inside parameter list
         const Elf_Shdr *symtab);

vim +237 include/linux/kexec.h

   226	/* kexec interface functions */
   227	extern void machine_kexec(struct kimage *image);
   228	extern int machine_kexec_prepare(struct kimage *image);
   229	extern void machine_kexec_cleanup(struct kimage *image);
   230	extern asmlinkage long sys_kexec_load(unsigned long entry,
   231						unsigned long nr_segments,
   232						struct kexec_segment __user *segments,
   233						unsigned long flags);
   234	extern int kernel_kexec(void);
   235	extern struct page *kimage_alloc_control_pages(struct kimage *image,
   236							unsigned int order);
 > 237	extern int kexec_load_purgatory(struct kimage *image, struct kexec_buf *kbuf);
   238	extern int kexec_purgatory_get_set_symbol(struct kimage *image,
   239						  const char *name, void *buf,
   240						  unsigned int size, bool get_value);
   241	extern void *kexec_purgatory_get_symbol_addr(struct kimage *image,
   242						     const char *name);
   243	extern void __crash_kexec(struct pt_regs *);
   244	extern void crash_kexec(struct pt_regs *);
   245	int kexec_should_crash(struct task_struct *);
   246	int kexec_crash_loaded(void);
   247	void crash_save_cpu(struct pt_regs *regs, int cpu);
   248	extern int kimage_crash_copy_vmcoreinfo(struct kimage *image);

0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 29777 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20180301/fc22da3d/attachment-0001.gz>

More information about the kexec mailing list