[PATCH] arm64: Set -fno-PIC along with -mcmodel=large

Simon Horman horms at verge.net.au
Thu Apr 19 01:21:05 PDT 2018


On Wed, Apr 18, 2018 at 12:45:59PM -0400, David Michael wrote:
> On Wed, Apr 18, 2018 at 8:54 AM, Simon Horman <horms at verge.net.au> wrote:
> > On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote:
> >> Hi Simon,
> >>
> >> On 02/02/2018 03:48 PM, Geoff Levand wrote:
> >> > Hi,
> >> >
> >> > On 01/07/2018 08:26 AM, David Michael wrote:
> >> >> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large
> >> >> code model is unsupported.  This fixes the "sorry, unimplemented"
> >> >> errors when building with compilers defaulting to -fPIC.
> >> >> ---
> >> >>
> >> >> purgatory/arch/arm64/entry.S:1:0: sorry, unimplemented: code model 'large' with -fPIC
> >> >>
> >> >> This change fixes it.  Can something like this be applied?
> >> >
> >> > This change seems reasonable considering large model + PIC is unsupported.
> >> >
> >> > Reviewed by: Geoff Levand <geoff at infradead.org>
> >>
> >> Could you please merged this fix so arm64 builds work OK on Gentoo
> >> and Gentoo derivatives.
> >
> > Sure, but it really ought to have a Signed-off-by line from David.
> 
> Sorry about that.  Should I resend the patch, or can you amend it with
> this line?
> 
> Signed-off-by: David Michael <david.michael at coreos.com>

Thanks, applied.



More information about the kexec mailing list