[PATCH 2/2] Revert "[PATCH V2 1/4] x86_64: Calculate page_offset from pt_load"
d.hatayama at jp.fujitsu.com
Wed May 24 18:11:32 PDT 2017
> -----Original Message-----
> From: Pratyush Anand [mailto:panand at redhat.com]
> Sent: Wednesday, May 24, 2017 3:21 PM
> To: Hatayama, Daisuke <d.hatayama at jp.fujitsu.com>
> Cc: 'kexec at lists.infradead.org' <kexec at lists.infradead.org>;
> 'bhe at redhat.com' <bhe at redhat.com>; 'ats-kumagai at wm.jp.nec.com'
> <ats-kumagai at wm.jp.nec.com>
> Subject: Re: [PATCH 2/2] Revert "[PATCH V2 1/4] x86_64: Calculate page_offset
> from pt_load"
> On Wednesday 24 May 2017 11:13 AM, Pratyush Anand wrote:
> > Hi Hatayama,
> > On Wednesday 24 May 2017 07:39 AM, Hatayama, Daisuke wrote:
> >> How about this?
> >> - return immediately in case of kaslr because there's no need to refer to
> >> PT_LOAD entries,
> >> - refer to PT_LOAD entries only if they exist, and
> >> - finally try to get page offset according to kernel versions.
> > It looks fine to me.
> > So if you agree then I can send next revision with your "Suggested-by" tag.
> return TRUEin case of KASLR success was missing in above. Fixed that.
It looks good to me.
More information about the kexec