[Makedumpfile PATCH] elf_info: fix file_size if segment is excluded

Pratyush Anand panand at redhat.com
Tue May 9 06:20:19 PDT 2017



On Tuesday 09 May 2017 07:59 AM, Atsushi Kumagai wrote:
>>> +                temp_seg.file_size = temp_seg.phys_end
>>> +                    - temp_seg.phys_start;
>>>
>>>                (*pt_loads)[i].virt_end = kvstart - 1;
>>>                (*pt_loads)[i].phys_end =  start - 1;
>>> +                (*pt_loads)[i].file_size -= temp_seg.file_size;
> I think we should additionally subtract (end - start), right ?
> This code seems to leave Crash Kernel region for the former half of PT_LOAD.

yes, you are right.

Will send v2.

Thanks for review.

~Pratyush



More information about the kexec mailing list