[Makedumpfile Patch v3 7/7] mem-usage: allow to work only with -f for kernel version < 4.11

Pratyush Anand panand at redhat.com
Thu Mar 2 18:48:47 PST 2017



On Friday 03 March 2017 07:40 AM, Atsushi Kumagai wrote:
>> +		if (info->kernel_version < KERNEL_VERSION(4, 11, 0) &&
>> +				!info->flag_force) {
>> +			MSG("mem-usage not supported for this kernel.\n");
>> +			MSG("You can try with -f if your kernel's kcore has valid p_paddr\n");
>> +			goto out;
>> +		}
> You forgot to set COMPLETED to retcd before goto.
> The behavior will be different from the v2 patch.


I had thought about it. Should not an unsupported feature be a FAILED case?

~Pratyush



More information about the kexec mailing list