[PATCH] ifdown: if socket can not be opened, then no need to close it

[Pratyush Anand]

On Tuesday 28 February 2017 01:40 PM, Pingfan Liu wrote:
> Signed-off-by: Pingfan Liu <piliu at redhat.com>
> ---
>  kexec/ifdown.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kexec/ifdown.c b/kexec/ifdown.c
> index 9679ad7..a5067ae 100644
> --- a/kexec/ifdown.c
> +++ b/kexec/ifdown.c
> @@ -34,7 +34,7 @@ int ifdown(void)
>  	if ((fd = socket(AF_INET, SOCK_DGRAM, 0)) < 0) {
>  		fprintf(stderr, "ifdown: ");
>  		perror("socket");
> -		goto error;
> +		goto exit;

may be 'return -1 ' from here itself..

anyway..both are fine.

>  	}
>
>  	if ((ifa = if_nameindex()) == NULL) {
> @@ -74,5 +74,6 @@ int ifdown(void)
>
>  error:
>  	close(fd);
> +exit:
>  	return -1;
>  }
>

Reviewed-by: Pratyush Anand <panand at redhat.com>