[PATCH 2/2] makedumpfile: Clean up unused KERNEL_IMAGE_SIZE

[Atsushi Kumagai]

>> >> > The old MODULES_VADDR need be decided by KERNEL_IMAGE_SIZE when kaslr
>> >> > enabled. Now MODULES_VADDR is not needed any more since Pratyush makes
>> >> > all VA to PA converting done by page table lookup. So remove its related
>> >> > code.
>> >>
>> >> Hi Bao,
>> >>
>> >> I'm not clear on this.  The crash utility still reads/needs KERNEL_IMAGE_SIZE
>> >> from the dumpfile's vmcoreinfo data.  Is it being written to the vmcoreinfo
>> >> section somewhere else in the code?
>> >
>> >Aha, seems makedumpfile will get the vmcoreinfo offset and size, then
>> >write the whole vmcoreinfo block into dumped vmcore header. But if
>> >specify '-g' for makedumpfile to only generate a vmcoreinfo file, it
>> >won't contain KERNEL_IMAGE_SIZE.
>> >
>> >makedumpfile -g vmcoreinfo -x vmlinux
>> >
>> >So I am not sure if you care about vmcoreinfo file, but you are right, I
>> >should not remove the vmcoreinfo reading and writing data.
>> >
>> >Thanks for pointing it out, will send v2 post.
>>
>> I understand the vmcoreinfo file generated by '-g' is used only for
>> makedumpfile, so it's OK if it doesn't contain KERNEL_IMAGE_SIZE since
>> crash doesn't refer to the file.
>> This patch doesn't modify the original vmcoreinfo section in dumpfile,
>> it sounds reasonable to me.
>
>Thanks for your comments, Atsushi! Then I am fine.

Additionally, I think it would be better to remove all of the code
you added in commit 56649f7b6bfe7.


Thanks,
Atsushi Kumagai