[PATCH] makedumpfile: Fix compilation warning

Atsushi Kumagai ats-kumagai at wm.jp.nec.com
Fri May 27 02:22:25 PDT 2016


Hello, Andrey

Sorry for my late reply, I'll merge this into v1.6.0.

Thanks,
Atsushi Kumagai

>After commit 5bc1f520
>[Looking for page.compound_order/compound_dtor to exclude hugepages]
>during build appears following compilation warning:
>
>makedumpfile.c: In function ‘isHugetlb’:
>makedumpfile.c:244:1: warning: type of ‘dtor’ defaults to ‘int’
>[-Wimplicit-int]
> isHugetlb(dtor)
>  ^
>
>Tested with gcc 5.3.1.
>
>Signed-off-by: Andrey Skvortsov <andrej.skvortzov at gmail.com>
>---
> makedumpfile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/makedumpfile.c b/makedumpfile.c
>index ce9fba6..4f17686 100644
>--- a/makedumpfile.c
>+++ b/makedumpfile.c
>@@ -241,7 +241,7 @@ is_in_same_page(unsigned long vaddr1, unsigned long vaddr2)
> }
>
> static inline int
>-isHugetlb(dtor)
>+isHugetlb(int dtor)
> {
>         return ((NUMBER(HUGETLB_PAGE_DTOR) != NOT_FOUND_NUMBER)
> 		&& (NUMBER(HUGETLB_PAGE_DTOR) == dtor))
>--
>2.8.1
>
>
>_______________________________________________
>kexec mailing list
>kexec at lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/kexec


More information about the kexec mailing list