[PATCH] makedumpfile: support _count -> _refcount rename in struct page

Vitaly Kuznetsov vkuznets at redhat.com
Thu Jun 16 07:01:58 PDT 2016


Dave Anderson <anderson at redhat.com> writes:

> ----- Original Message -----
>> _count member was renamed to _refcount in linux commit commit 0139aa7b7fa12
>> ("mm: rename _count, field of the struct page, to _refcount") and this
>> broke makedumpfile. The reason for making the change was to find all users
>> accessing it directly and not through the recommended API. I tried
>> suggesting to revert the change but failed, I see no other choice than to
>> start supporting both _count and _refcount in makedumpfile.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets at redhat.com>
>> ---
>> - 'crash' tool is now broken as well.
>
> FYI, crash was fixed upstream a few weeks ago:
>
>   commit 8ceb1ac628bf6a0a7f0bbfff030ec93081bca4cd
>   Author: Dave Anderson <anderson at redhat.com>
>   Date:   Mon May 23 11:23:01 2016 -0400
>
>     Fix for Linux commit 0139aa7b7fa12ceef095d99dc36606a5b10ab83a, which
>     renamed the page._count member to page._refcount.  Without the patch,
>     certain "kmem" commands fail with the "kmem: invalid structure member
>     offset: page_count".
>     (anderson at redhat.com)

Missed that, thanks for the heads up!

-- 
  Vitaly



More information about the kexec mailing list