[PATCH] Revert "kexec: use mmap instead of read for slurp_file()"

Dave Young dyoung at redhat.com
Mon Nov 2 17:15:11 PST 2015


Hi, Geoff

On 11/02/15 at 04:11pm, Geoff Levand wrote:
> Hi,
> 
> On Fri, 2015-10-23 at 11:10 +0800, Dave Young wrote:
> > This reverts commit 7ab842d8a004f6cd75a9d7b3528e4a70819ce4ef.
> > 
> > using mmap by default in slurp_file cause segment fault while later
> > reallocing dtb_buf during my arm kexec test.
> 
> Could you say more about the cause of the segfault?  Where is the dtb
> reallocated?

See kexec-zImage-arm.c:
slurp_file --> setup_dtb_prop --> xrealloc

Thanks
Dave



More information about the kexec mailing list