[PATCH 0/13] makedumpfile: Avoid two pass filtering by using bitmap file.

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Tue May 12 01:20:35 PDT 2015


Hello Kumagai-san,

From: Atsushi Kumagai <ats-kumagai at wm.jp.nec.com>
Subject: [PATCH 0/13] makedumpfile: Avoid two pass filtering by using bitmap file.
Date: Mon, 11 May 2015 06:13:51 +0000

> Hello,
> 
> This is the patch set to avoid two pass filtering, it is the
> finished version of the previous patch set below:
> 
>   http://lists.infradead.org/pipermail/kexec/2015-March/013497.html
> 
> 
> cyclic mode has to take a two-pass approach for filtering to save on the
> memory consumption, it's a disadvantage of the cyclic mode and it's basically
> unavoidable. However, even the cyclic mode can avoid two-pass filtering if free
> memory space is enough to store the whole 1st and 2nd bitmaps, but the current
> version doesn't it.
> The main purpose of this patch set is avoiding that useless filtering,
> but before that, I merged non-cyclic mode into cyclic mode as code clean up 
> because the codes are almost the same. Instead, I introduce another way to
> guarantee one-pass filtering by using disk space.
> 

How about compromising progress information to some extent? The first
pass is intended to count up the exact number of dumpable pages just
to provide precise progress information. Is such prcision really
needed?

For example, how about another simple progress information:

   pfn / max_mapnr

where pfn is the number of a page frame that is currently
processed. We know max_mapnr from the beginning, so this is possible
within one pass. It's less precise but might be precise enough.

--
Thanks.
HATAYAMA, Daisuke




More information about the kexec mailing list