[PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path
Eric W. Biederman
ebiederm at xmission.com
Tue Mar 24 03:27:10 PDT 2015
Ingo Molnar <mingo at kernel.org> writes:
> * Masami Hiramatsu <masami.hiramatsu.pt at hitachi.com> wrote:
>> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option for kdump after panic_notifers")
>> > Was that crash_kexec() was called unconditionally after notifiers were
>> > called, which should be fixed via the simple patch below (untested).
>> > Looks much simpler than your fix.
>> No, Daisuke's patch is not for that case. [...]
> Yet the actual bug is in that commit, 'crash_kexec_post_notifiers' was
> clearly not a no-op in the default case, against expectations.
> So the first step should be to restore the original behavior (my
> patch), then should any new tweaks be added.
Honestly I think the proper fix is to simply revert f06e5153f4ae.
It was clearly not properly tested by the people who wanted it because
they came back quite a while later with additional bleh.
I think this pretty much counts as hitting the code doesn't work let's
remove it threshold.
More information about the kexec