[PATCH] multiboot: fix crash on NULL kernel command line

Ameya Palande 2ameya at gmail.com
Thu Feb 12 00:04:41 PST 2015


On Wed, Feb 11, 2015 at 3:08 PM, Simon Horman <horms at verge.net.au> wrote:
> On Thu, Feb 05, 2015 at 01:36:24PM -0800, Ameya Palande wrote:
>> If "--command-line" option is not specified, then kexec segfaults while
>> dereferencing NULL command line string pointer. While we are at it, also
>> fix indentation and use '{' and '}' consistently.
>>
>> Signed-off-by: Ameya Palande <2ameya at gmail.com>
>
> Somehow I missed this. Please CC me on patches for kexec-tools as
> it makes it easier for me to see them.

Sure!

> Please resubmit this patch split up so that fixes and cleanups are separate.
> One patch per issue is the rule of thumb. This makes it easier to review
> and prioritise patches.

Looks like you already applied it :) Thanks!

Cheers,
Ameya.



More information about the kexec mailing list