[PATCH] multiboot: fix crash on NULL kernel command line

Minfei Huang mhuang at redhat.com
Wed Feb 11 19:29:18 PST 2015


On 02/11/15 at 09:22am, Ameya Palande wrote:
> On Tue, Feb 10, 2015 at 8:00 AM, Ameya Palande <2ameya at gmail.com> wrote:
> > On Thu, Feb 5, 2015 at 1:36 PM, Ameya Palande <2ameya at gmail.com> wrote:
> >> If "--command-line" option is not specified, then kexec segfaults while
> >> dereferencing NULL command line string pointer. While we are at it, also
> >> fix indentation and use '{' and '}' consistently.
> >>
> >> Signed-off-by: Ameya Palande <2ameya at gmail.com>
> >
> > Any update on this one?
> 
> Is there anything wrong with this patch? Is this the correct mailing
> list for exec-tools related patch?
> 
> Cheers,
> Ameya.

As Simon's comment in this thread, you should split up your patch to
separate the fix and cleanup to be reviewed clearly.

Thanks
Minfei

> 
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec



More information about the kexec mailing list