[PATCH 3/4] arm64: Fix KVBASE

Pratyush Anand panand at redhat.com
Sun Dec 6 22:16:53 PST 2015


Hi Timur,

Thanks for your review.

On 05/12/2015:10:34:14 AM, Timur Tabi wrote:
> Pratyush Anand wrote:
> >+		& (0xffffffffffffffffUL << (VA_BITS - 1));
> 
> Shouldn't this be ULL instead of just UL?

I think on 64 bit platform, unsigned long is always 64 bit (with gcc). More
over, info->page_offset is unsigned long. So, I think using UL would be in sync,
no?

~Pratyush



More information about the kexec mailing list