[V5 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly

Borislav Petkov bp at alien8.de
Wed Dec 2 07:40:23 PST 2015


On Wed, Dec 02, 2015 at 11:57:38AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote:
> We can do so, but I think resetting panic_cpu always would be
> simpler and safer.

Well, I think executing code needlessly *especially* at panic time is
not all that rosy either.

Besides something like this:

	static bool kexec_failed;

	...

        if (crash_kexec_post_notifiers && !kexec_failed)
		kexec_failed = __crash_kexec(NULL);

is as simple as it gets.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.



More information about the kexec mailing list