[PATCH] purgatory: Disabling GCC's stack protection

Kevin Hao kexin.hao at windriver.com
Wed Apr 29 22:21:24 PDT 2015


On Thu, Apr 30, 2015 at 02:08:09PM +0900, Simon Horman wrote:
> On Thu, Apr 30, 2015 at 01:39:50PM +0900, Simon Horman wrote:
> > Hi Kevin,
> > 
> > On Tue, Apr 28, 2015 at 08:50:19PM +0800, Kevin Hao wrote:
> > > If the GCC's stack protection is enabled by default, the purgatory will
> > > also be built with this option. But it makes no sense to enable this
> > > for the purgatory code, and would cause error when we are trying to
> > > relocate the purgatory codes because symbol like __stack_chk_fail is
> > > unresolved. Instead of disabling this for some archs specifically,
> > > disable it for all the archs.
> > > 
> > > Signed-off-by: Kevin Hao <kexin.hao at windriver.com>
> > 
> > This seems like a reasonable change to me, however, it does
> > not apply cleanly to the kexec tree on kernel.org which I maintain.
> > 
> > https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git
> > 
> > Could you rebase and repost?
> 
> I have now realised that Mike Frysinger has posted a similar,
> slightly more comprehensive, patch which I have now applied.
> 
> Could you see if it addresses the problem you are seeing?
> 
> It is the following commit in the above tree:
> 
> 4a837c9a19f9 purgatory: force PIC/PIE/SSP off

Yes, it should solve my problem too. I didn't realized there already have
a patch for this issue. Sorry for the noise.

Thanks,
Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20150430/dfe7d1c7/attachment.sig>


More information about the kexec mailing list