[PATCH RFC 6/6] arm64: wait for transmit completion before next character transmission

Pratyush Anand panand at redhat.com
Sun Apr 19 20:34:01 PDT 2015



On Monday 20 April 2015 08:28 AM, Baoquan He wrote:
> On 04/17/15 at 11:07am, Pratyush Anand wrote:
>>
>>
>> On Friday 17 April 2015 11:06 AM, Minfei Huang wrote:
>>>>   	.quad	0
>>>>>   size arm64_dtb_addr
>>>>> +
>>>>> +.globl arm64_sink_lsr_val
>>>>> +arm64_sink_lsr_val:
>>>>> +	.word	0
>>> Since arm64_sink_lsr_val is declared as uint32_t, it is better to keep
>>> the same format here.
>
> ".word" only stores 16bit, doesn't it? Should it be ".int" or ".long"?

I see that .word, .int and .long all reserve 4 bytes for ARM64. But may 
be using .int could be better.

However, as Geoff suggested to remove port-lsr and port-lsr-val, so we 
will not need these.

~Pratyush

> You can check gnu as manual for reference.
>
> Thanks
> Baoquan
>
>>>
>>
>> I thought .word will do the same. But may be I am wrong. What is the
>> good syntax for uint32_t.
>>
>> ~Pratyush
>>
>> _______________________________________________
>> kexec mailing list
>> kexec at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>



More information about the kexec mailing list