[PATCH v2] vmcore-dmesg: Understand >= v3.11-rc4 dmesg

Vivek Goyal vgoyal at redhat.com
Thu May 22 06:51:01 PDT 2014

On Thu, Oct 31, 2013 at 09:42:32AM -0700, Taras Kondratiuk wrote:


This patch has not gone it for quite some time and vmcore-dmesg continues
to fail for me with upstream kernels. So it is time to do something
about it.

> I have concerns about this patch.
> There were a lot of hardcoded lenght values in the original code.

One can easily fix that by using strlen().

> Now there are twice as much and we need to keep adding hardcoded
> values if any additional parameter should be read of renamed.
> Please eveluate this patch [1]. It should remove both:
> hardcoded values and duplicated reading for two buffer names.

I don't like excessive usage of macros. And in your patch you are
using nested marcros.

While it might make look code smaller, readability of code becomes
a problem. 

So I personally like simpler approach. And please use strlen() for
fixing the hardcoding of length issue.


More information about the kexec mailing list