[PATCH] kdump: Fix exported size of vmcoreinfo note
akpm at linux-foundation.org
Tue Jan 14 18:35:54 EST 2014
On Tue, 14 Jan 2014 14:33:11 -0500 Vivek Goyal <vgoyal at redhat.com> wrote:
> Right now we seem to be exporting the max data size contained inside
> vmcoreinfo note. But this does not include the size of meta data around
> vmcore info data. Like name of the note and starting and ending elf_note.
> I think user space expects total size and that size is put in PT_NOTE
> elf header. Things seem to be fine so far because we are not using
> vmcoreinfo note to the maximum capacity. But as it starts filling up,
> to capacity, at some point of time, problem will be visible.
urgh. This is what we get for adding undocumented interfaces.
Looking through the fd59d231f81cb0287 changelog and the various email
threads it points to I can find no mention of what vmcoreinfo is
*supposed* to contain. It was just kinda silently tossed in there.
So as a remedial step, could we please get this and any associated
interfaces written down in a way which people can very belatedly
Phrases like "I think user space expects" and "Things seem to be fine
so far" don't inspire a ton of confidence. What are the chances of
userspace breakage here? Would it be safer/saner to leave vmcoreinfo
alone and add a new vmcoreinfo2 with the altered behaviour?
> --- linux-2.6.orig/kernel/ksysfs.c 2014-01-14 14:09:42.107767503 -0500
> +++ linux-2.6/kernel/ksysfs.c 2014-01-14 14:15:24.385510314 -0500
> @@ -126,7 +126,7 @@ static ssize_t vmcoreinfo_show(struct ko
> return sprintf(buf, "%lx %x\n",
> - (unsigned int)vmcoreinfo_max_size);
> + (unsigned int)sizeof(vmcoreinfo_note));
More information about the kexec