[PATCH] makedumpfile: clean up draft patch

Baoquan He bhe at redhat.com
Mon Jan 6 20:49:48 EST 2014

Hi Atsushi,

Could you please review this draft patch? As we discussed before,
function update_cyclic_region not only update the cyclic region, but
also handle the 1st bitmap and 2nd bitmap. For better understanding and
process, it need be cleaned up. In this patch, struct cycle is
introduced and can be passed down into functions, but not global. I
think this clean up is helpful, and no risk.

What'a your opinion?


On 12/27/13 at 08:12pm, Baoquan He wrote:
> Introduce the struct cycle as below just as Hatamaya expected.
> struct cycle {
>         uint64_t start_pfn;
>         uint64_t end_pfn;
> };
>   for (first_cycle(start, max, C); !end_cycle(max, C); \
>        update_cycle(max, C))
> Hi Atsushi and HATAYAMA,
> Please help review this draft patch and check if there's any potentia
> risk. If you think this is in the right way, I can post a formal
> patchset. I just test the normal operation on kdump and elf format,
> it works well.
> Signed-off-by: Baoquan He <bhe at redhat.com>
> ---

More information about the kexec mailing list