[PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

Prarit Bhargava prarit at redhat.com
Tue Dec 30 06:57:51 PST 2014


panic_on_warn kernel parameter will cause the kernel to panic when a
WARN() is hit in the kernel.  This is not a good situation for the kdump
kernel because then it would be possible for the kdump kernel to panic in
a non-fatal WARN().

This patch removes panic_on_warn as a kernel parameter for the kdump
kernel.

Signed-off-by: Prarit Bhargava <prarit at redhat.com>
Cc: Dave Young <dyoung at redhat.com>
Cc: Vivek Goyal <vgoyal at redhat.com>
Cc: WANG Chao <chaowang at redhat.com>
---
 kexec/kexec.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kexec/kexec.c b/kexec/kexec.c
index b088916..323cafb 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1048,8 +1048,10 @@ char *get_command_line(void)
 	line[strlen(line) - 1] = '\0';
 
 	remove_parameter(line, "BOOT_IMAGE");
-	if (kexec_flags & KEXEC_ON_CRASH)
+	if (kexec_flags & KEXEC_ON_CRASH) {
 		remove_parameter(line, "crashkernel");
+		remove_parameter(line, "panic_on_warn");
+	}
 
 	return line;
 }
-- 
1.7.9.3




More information about the kexec mailing list