[Patch v3 3/7] preparation functions for parsing vmcoreinfo

bhe at redhat.com bhe at redhat.com
Thu Aug 14 01:15:32 PDT 2014

On 08/14/14 at 07:37am, Atsushi Kumagai wrote:
> >On 08/12/14 at 05:46pm, Baoquan He wrote:
> >
> >I add the static variable "done" just because it always print below
> >warning message twice, this makes me uncomfortable. Otherwise
> >get_kernel_version() can be called any time no matter how many times it
> >has been called if it's only a converting utility function.
> >
> >The kernel version is not supported.
> >The created dumpfile may be incomplete.
> Yeah, I understand the reason.
> I agree with your idea, but I think it's better to check the
> kernel_version directly like:
> 	if (info->kernel_version)
> 		return info->kernel_version;

Well, I got what you meant. I didn't get it when you said at first
time. Yeah, this works and is better. Will change like this. Thanks a

> Thanks
> Atsushi Kumagai
> >
> >_______________________________________________
> >kexec mailing list
> >kexec at lists.infradead.org
> >http://lists.infradead.org/mailman/listinfo/kexec

More information about the kexec mailing list