[RFC PATCH]: merge identical code

[Atsushi Kumagai]

>On 2014/4/10 15:56, Atsushi Kumagai wrote:
>> Hello Wang,
>>
>>> Hi Kumagai,
>>>
>>> I found that in makedumpfile.c, there are many code like following:
>>>
>>>  if (info->flag_cyclic) {
>>>      proc_cyclic();
>>>  } else {
>>>      proc();
>>>  }
>>>
>>> The logical and code of proc_cyclic and proc are nearly identical.
>>>
>>> Do you want to merge them together?
>>
>> Yes, I think we should do this work.
>>
>> However, the similarity of them will be reduced since how to update
>> cyclic region is going to be changed in v1.5.6.
>> If you can carry out this work also for v1.5.6, I'll accept it.
>>
>> You can use the current devel branch because it's almost v1.5.6.
>> (Formally, v1.5.6 will be released next week.)
>>
>> https://sourceforge.net/p/makedumpfile/code/ci/devel/tree/
>>
>>
>> Thanks
>> Atsushi Kumagai
>>
>
>What about totaly remove non-cyclic functions and use a very large cyclic?

I also think it's a better way, give it a go :-)


Thanks
Atsushi Kumagai