[PATCH] kexec/ppc: cleanup crash regions creation

Simon Horman horms at verge.net.au
Wed Apr 9 16:22:54 PDT 2014


On Fri, Mar 21, 2014 at 02:58:57PM +0400, Nikita Yushchenko wrote:
> > Move filling crash_memory_range table entries into a separate routine,
> > which saves quite a few lines of code.
> > 
> > In this routine, if range spawns over lowmem-highmem border, split range
> > into two. This is needed to get proper virtual address for lowmem part.
> > Similar thing is already done for x86. Credits to Yadviga Grigorieva
> > <yadviga at dev.rtsoft.ru> for tracking down this issue for ppc.
> > 
> > Also this patch makes excluding crash kernel region a bit shorter, and
> > removes unused variable to get rid of compiler warning.
> > 
> > Signed-off-by: Nikita Yushchenko <nyushchenko at dev.rtsoft.ru>
> > ---
> >  kexec/arch/ppc/crashdump-powerpc.c |  108 +++++++++++++++++-------------------
> >  1 files changed, 51 insertions(+), 57 deletions(-)
> 
> Hi
> 
> Any followup on this?
> 
> Without this patch, vmcore files extracted with kdump is not very useful with gdb:

Apologies for the delay, I have applied this patch.




More information about the kexec mailing list