[PATCH 0/2] Generic multi-page exclusion

Petr Tesarik ptesarik at suse.cz
Fri Apr 4 11:26:22 EDT 2014

On Fri,  4 Apr 2014 11:56:07 +0200
Petr Tesarik <ptesarik at suse.cz> wrote:

> Kumagai-san,
> this patch was inspired by this post of yours:
> http://lists.infradead.org/pipermail/kexec/2013-November/010445.html
> Unfortunately, this rewrite never happened, so I took the liberty of
> overtaking the job. I hope you don't mind.
> This is in fact a preparatory series to add hugepage support without
> having to care about the appropriate size of the cyclic buffer.

Scratch it. The algorithm assumes that work resumes exactly where it
left in a previous run of __exclude_unnecessary_pages. While this is
true for all dumps I have, the function is in fact invoked per-mm, so if
there are two nodes in the cyclic buffer and they are not in ascending
order by physical address, the algorithm may fail. That's simply not
robust enough by my standards, so I'm going to respin this patch set.

Sorry if I've already wasted some of your time.

Petr Tesarik

More information about the kexec mailing list