[PATCH] makedumpfile: use non-cyclic when possible

Atsushi Kumagai kumagai-atsushi at mxc.nes.nec.co.jp
Mon Sep 9 03:55:08 EDT 2013


(2013/08/30 9:40), HATAYAMA Daisuke wrote:
> (2013/08/29 7:08), Cliff Wickman wrote:
>> From: Cliff Wickman <cpw at sgi.com>
>>
>> If there is plenty of memory use non-cyclic mode.
>>
> 
> If there is enough memory to use, the number of cycle is 1.
> Cyclic mode in 1-cycle is the same as non-cyclic mode in theory.
> If slow, it's better to improve cyclic mode implementation.
> 
> To be honest, I think the current non-cyclic mode should be implemented as 1-cycle case. 
> Then, makedumpfile can reduce amount of code at the same time. 

Yes, I hope to get rid of non-cyclic mode.
When v1.5.0 was released, I retained non-cyclic mode as just
workaround since cyclic mode has big performance issue.
However, we have done some improvement for cyclic mode and
we will continue it.

So please don't make the code depend on non-cyclic mode and
make efforts to get rid of it.


Thanks
Atsushi Kumagai



More information about the kexec mailing list