[PATCH v2] vmcore-dmesg: Understand >= v3.11-rc4 dmesg

[Simon Horman]

On Thu, Oct 31, 2013 at 09:42:32AM -0700, Taras Kondratiuk wrote:
> On 10/30/2013 11:20 PM, Simon Horman wrote:
> > On Thu, Oct 31, 2013 at 01:38:08PM +0800, WANG Chao wrote:
> >> On 10/30/13 at 06:06pm, Lubomir Rintel wrote:
> >>> Hi,
> >>>
> >>> On Wed, 2013-10-30 at 11:12 +0800, WANG Chao wrote:
> >>>> On 09/19/13 at 04:49pm, Lubomir Rintel wrote:
> >>>>> Symbol name changed with the following commit:
> >>>>> 62e32ac printk: rename struct log to struct printk_log
> >>> ...
> >>>> vmcore-dmesg is really broken here since 3.11 kernel is released. Are
> >>>> you going to send an update v3 to address the comments to v2 from Vivek,
> >>>> Joe and Dave
> >>>
> >>> I'm not really sure. I thought the suggestions were concerning the Linux
> >>> kernel tree, not kexec-tools tree. I might be wrong though, but I'd need
> >>> the suggestions to be a bit more specific for me to understand.
> >>
> >> That wouldn't be your concern any more. I think your patch is fine.
> >> Thank you for fix.
> >>
> >> Hi Simon,
> >>
> >> Will you pick up this patch? Vivek and Dave has acked this patch.
> >> And also this patch works for me.
> > 
> > Sure. Please repost it with the Acks.
> 
> I have concerns about this patch.
> There were a lot of hardcoded lenght values in the original code.
> Now there are twice as much and we need to keep adding hardcoded
> values if any additional parameter should be read of renamed.
> 
> Please eveluate this patch [1]. It should remove both:
> hardcoded values and duplicated reading for two buffer names.
> 
> [1] http://permalink.gmane.org/gmane.linux.kernel.kexec/9522

Please repost the patch.