[PATCH v5 5/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory

Vivek Goyal vgoyal at redhat.com
Tue May 14 11:57:55 EDT 2013

On Tue, May 14, 2013 at 10:57:35AM +0900, HATAYAMA Daisuke wrote:

> +/* Merges all the PT_NOTE headers into one. */
> +static int __init merge_note_headers_elf32(char *elfptr, size_t *elfsz,
> +					   char **notesegptr, size_t *notesegsz,
> +					   struct list_head *vc_list)
> +{

Given that we are copying notes in second kernel, we are not using vc_list
in merge_note_headers() any more. So remove vc_list from paramter list

For local parameters we could simply use notes_buf (instead of notesgptr)
and notes_sz (instead of notesgsz). It seems mroe readable.


More information about the kexec mailing list