failed to compile kexec from git

Simon Horman horms at verge.net.au
Wed Mar 13 05:52:11 EDT 2013


On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote:
> If I revert this commit,
> 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
> kexec x86: drop truncation warning for crash kernel
> 
> Everything is fine again.

Thanks. I have applied the following patch which I believe resolves
the problem. Cliff, could you test this?

commit 51438a32f6a0f09a358742f06196d14e4ad0ccab
Author: Simon Horman <horms at verge.net.au>
Date:   Wed Mar 13 10:48:48 2013 +0100

    Correct build failure in init_linux_parameters()
    
    This fixes a build failure introduced by
    "kexec x86: drop truncation warning for crash kernel".
    
    Reported-by: CAI Qian <caiqian at redhat.com>
    Cc: Cliff Wickman <cpw at sgi.com>
    Signed-off-by: Simon Horman <horms at verge.net.au>

diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index b903d43..454fad6 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
 	range = info->memory_range;
 	ranges = info->memory_ranges;
 	if (ranges > E820MAX) {
-		if (!(kexec_flags & KEXEC_ON_CRASH))
+		if (!(info->kexec_flags & KEXEC_ON_CRASH))
 			/*
 			 * this e820 not used for capture kernel, see
 			 * do_bzImage_load()




More information about the kexec mailing list