[PATCH] makedumpfile, sadump: fix bug in checking a given physical address is present on memory

Atsushi Kumagai kumagai-atsushi at mxc.nes.nec.co.jp
Mon Jan 21 03:18:54 EST 2013


Hello HATAYAMA-san,

Thanks for your three patches for sadump.
I'll merge them to v1.5.2.


Thanks
Atsushi Kumagai

On Mon, 21 Jan 2013 15:15:01 +0900 (JST)
HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote:

> Due to lack of checking if sadump flag, interface for ELF had been
> used wrongly for sadump format. By this, all the ranges had been
> ignored and most kinds of filtering had been failed except for zero
> pages.
> 
> Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
> ---
>  makedumpfile.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/makedumpfile.c b/makedumpfile.c
> index 314dc46..7ce7138 100644
> --- a/makedumpfile.c
> +++ b/makedumpfile.c
> @@ -3027,7 +3027,7 @@ clear_bit_on_2nd_bitmap_for_kernel(unsigned long long pfn)
>  static inline int
>  is_in_segs(unsigned long long paddr)
>  {
> -	if (info->flag_refiltering) {
> +	if (info->flag_refiltering || info->flag_sadump) {
>  		static struct dump_bitmap bitmap1 = {0};
>  
>  		if (bitmap1.fd == 0)
> -- 
> 1.7.7.6
> 
> 



More information about the kexec mailing list