[PATCH] ARM: call disable_nonboot_cpus() from machine_shutdown()
Russell King - ARM Linux
linux at arm.linux.org.uk
Wed Jan 2 16:52:38 EST 2013
On Wed, Jan 02, 2013 at 02:07:41PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
>
> On Tegra at least, this change allows kexec to work with SMP enabled.
> Without this, machine_shutdown() simply puts all CPUs into a loop. If
> the code of that loop is over-written, the CPUs may hang or crash (which
> I do observe in practice), or cause the kexec'd kernel not to be able to
> initialize them.
>
> This fix has the added benefit that the kexec always happens on the boot
> CPU, and thus kexec mirrors the initial kernel boot as much as possible.
>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
> Russell, I assume this should go into the ARM patch tracker if OK?
I guess the discussions about getting this into the generic parts of
the kernel came to nothing?
So, yes.
>
> arch/arm/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f79dd1e..1893bda 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -239,6 +239,7 @@ __setup("reboot=", reboot_setup);
>
> void machine_shutdown(void)
> {
> + disable_nonboot_cpus();
> #ifdef CONFIG_SMP
> smp_send_stop();
> #endif
> --
> 1.7.10.4
>
More information about the kexec
mailing list