[PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data
Dave Young
dyoung at redhat.com
Thu Dec 12 02:17:43 EST 2013
> > >
> > > +void __init parse_efi_setup(u64 phys_addr)
> > > +{
> > > + struct setup_data *sd;
> > > +
> > > + if (!efi_enabled(EFI_64BIT)) {
> > > + pr_warn("SETUP_EFI not supported on 32-bit\n");
> > > + return;
> > > + }
> >
> > Shouldn't this function be in two versions in efi_64.c and efi_32.c?
> > This way you don't need this check with cryptic printk message.
>
> Ok, will update.
Rethink about this issue, moving them to efi_$(BITS).c I need move the
efi_setup from a static variable to an extern, It looks not worth.
Thanks
Dave
More information about the kexec
mailing list