[Xen-devel] [PATCH 4/8] kexec: add infrastructure for handling kexec images
JBeulich at suse.com
Tue Apr 9 03:44:30 EDT 2013
>>> On 08.04.13 at 20:59, David Vrabel <david.vrabel at citrix.com> wrote:
> + ret = kimage_add_page(image, page_to_mfn(page) << PAGE_SHIFT);
Constructs like this aren't portable. You ought to use
page_to_maddr(), and have the called function have paddr_t
instead of unsigned long as the respective parameter.
> + struct page_list_head unuseable_pages;
Also there appear to be a few hard tabs here and there.
More information about the kexec