[PATCH] kexec, i386: Fix build warning of size_t print

Simon Horman horms at verge.net.au
Sun Apr 7 22:08:14 EDT 2013


On Mon, Apr 08, 2013 at 09:38:49AM +0800, Zhang Yanfei wrote:
> 于 2013年04月08日 09:37, Simon Horman 写道:
> > On Sat, Apr 06, 2013 at 01:39:40PM +0800, Zhang Yanfei wrote:
> >> From: Zhang Yanfei <zhangyanfei at cn.fujitsu.com>
> >>
> >> When compile kexec-tools in i386, we got the following warnings:
> >>
> >> kexec/kexec-elf-rel.c: In function ‘elf_rel_set_symbol’:
> >> kexec/kexec-elf-rel.c:517: warning: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘size_t’
> >> kexec/kexec-elf-rel.c: In function ‘elf_rel_get_symbol’:
> >> kexec/kexec-elf-rel.c:541: warning: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘size_t’
> >>
> >> This is because the two functions output a size_t value as %ld
> >> when it should be %zd, resulting in this warning.
> > 
> > Thanks,
> > 
> > This change looks good to me, however, the patch does
> > not appear to apply on the master branch of the kexec-tools tree.
> > Could you rebase and repost it?
> 
> Really? Maybe I made some mistake. Anyway I will regenerate it and
> resend it again.

Perhaps I made a mistake ^)

The head commit I have is:

commit 969f3e8c1c534f63b869183ccf292bcaef0e5558
Author: Richard Weinberger <richard at nod.at>
Date:   Mon Apr 1 13:23:04 2013 +0200

    purgatory: remove arch/i386/timer.c
    
    This file is nowhere referenced, let's get rid of it.
    
    Signed-off-by: Richard Weinberger <richard at nod.at>
    Signed-off-by: Simon Horman <horms at verge.net.au>



More information about the kexec mailing list