[PATCH 2/2] [RFC] get rid of dist

Zhang Yanfei zhangyanfei at cn.fujitsu.com
Tue Apr 2 02:09:02 EDT 2013

于 2013年04月02日 13:55, Richard Weinberger 写道:
> Am 02.04.2013 07:51, schrieb Zhang Yanfei:
>> 于 2013年04月02日 13:36, Richard Weinberger 写道:
>>> Simon,
>>> Am 02.04.2013 03:10, schrieb Simon Horman:
>>>> On Mon, Apr 01, 2013 at 01:23:05PM +0200, Richard Weinberger wrote:
>>>>> Replace the dist variable by git ls-files.
>>>>> The following files are now included in the dist tarball too:
>>>> I'm sorry but I don't think it is reasonable to
>>>> add git as a requirement for building a tarball.
>>> It is not about building a tarball, it is about tracking files.
>>> Currently you are abusing make to keep track of your files.
>>> git does this already for you.
>>> Tracking files manually in the Makefile is also error prone.
>>> doc/mpc85xx.txt and arch/i386/timer.c have already been forgotten...
>>> If I'm not mistaken kexec-tools uses git as SCM, so you'll need
>>> git anyways to checkout the source and work with it.
>> I think what simon meant is that by using current ways, we can build a
>> tarball without git installed. By using your ways, if we want to build
>> a tarball, git is a must. So it is unnecessary to add git as a requirement
>> for there may be some condtions that we want to build a clean tarball in a
>> git-not-installed system.
> But git is already a requirement to checkout the source from the git repo.
> Or I'm mistaken?

Yeah, this is one case.

Someone may also download a kexec-tools tarball from internet,
and then want to build a RPM. Even git isn't installed in his system,
the RPM could be built.


More information about the kexec mailing list