[PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Sun Sep 2 23:16:37 EDT 2012


From: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
Subject: Re: [PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.
Date: Mon, 3 Sep 2012 11:50:57 +0900

> From: Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp>
> Subject: [PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.
> Date: Thu, 30 Aug 2012 16:45:21 +0900
> 
> <cut>
> 
>> diff --git a/makedumpfile.c b/makedumpfile.c
>> index d024e95..21bb55a 100644
>> --- a/makedumpfile.c
>> +++ b/makedumpfile.c
>> @@ -2553,6 +2553,8 @@ initial(void)
>>  							info->name_memory);
>>  			return FALSE;
>>  		}
>> +		info->flag_cyclic = FALSE;
>> +
> 
> Please disable cyclic mode on sadump dumpfiles, too.
> 

Also, there's no information to users about disabling cyclic mode.
Now switching from cyclic to normal mode is implicitly done. This is
confusing. I think some message indicating that, is necessary.

Thanks.
HATAYAMA, Daisuke




More information about the kexec mailing list