[PATCH v2 05/10] Add hardcoded page flag values

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Fri Nov 16 00:01:57 EST 2012


Although these values should basically be exported from VMCOREINFO, we
cannot modify old kernels. Luckily, these values had not so frequently
been changed that it's relatively easy to determine appropreate values
for a given kernel version without any symbol or type information.

On the other hand, the mem_map logic also needs the values for some
members of page structure. But it much depends on kernel versions. We
aovid to hard code the values.

Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
---

 makedumpfile.c |   32 ++++++++++++++++++++++++++++++++
 makedumpfile.h |    9 +++++++++
 2 files changed, 41 insertions(+), 0 deletions(-)

diff --git a/makedumpfile.c b/makedumpfile.c
index 0d03716..1a0151c 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -1210,6 +1210,38 @@ get_value_for_old_linux(void)
 		NUMBER(PG_private) = PG_private_ORIGINAL;
 	if (NUMBER(PG_swapcache) == NOT_FOUND_NUMBER)
 		NUMBER(PG_swapcache) = PG_swapcache_ORIGINAL;
+	if (NUMBER(PG_slab) == NOT_FOUND_NUMBER)
+		NUMBER(PG_slab) = PG_slab_ORIGINAL;
+	/*
+	 * The values from here are for free page filtering based on
+	 * mem_map array. These are minimum effort to cover old
+	 * kernels.
+	 *
+	 * The logic also needs offset values for some members of page
+	 * structure. But it much depends on kernel versions. We avoid
+	 * to hard code the values.
+	 */
+	if (NUMBER(PG_buddy) == NOT_FOUND_NUMBER) {
+		if (info->kernel_version >= KERNEL_VERSION(2, 6, 17)
+		    && info->kernel_version <= KERNEL_VERSION(2, 6, 26))
+			NUMBER(PG_buddy) = PG_buddy_v2_6_17_to_v2_6_26;
+		if (info->kernel_version >= KERNEL_VERSION(2, 6, 27)
+		    && info->kernel_version <= KERNEL_VERSION(2, 6, 37))
+			NUMBER(PG_buddy) = PG_buddy_v2_6_27_to_v2_6_37;
+	}
+	if (NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE) == NOT_FOUND_NUMBER) {
+		if (info->kernel_version == KERNEL_VERSION(2, 6, 38))
+			NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE) =
+				PAGE_BUDDY_MAPCOUNT_VALUE_v2_6_38;
+		if (info->kernel_version >= KERNEL_VERSION(2, 6, 39))
+			NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE) =
+			PAGE_BUDDY_MAPCOUNT_VALUE_v2_6_39_to_latest_version;
+	}
+	if (SIZE(pageflags) == NOT_FOUND_STRUCTURE) {
+		if (info->kernel_version >= KERNEL_VERSION(2, 6, 27))
+			SIZE(pageflags) =
+				PAGE_FLAGS_SIZE_v2_6_27_to_latest_version;
+	}
 	return TRUE;
 }
 
diff --git a/makedumpfile.h b/makedumpfile.h
index 1304df0..d69bcca 100644
--- a/makedumpfile.h
+++ b/makedumpfile.h
@@ -71,9 +71,18 @@ int get_mem_type(void);
  * The following values are for linux-2.6.25 or former.
  */
 #define PG_lru_ORIGINAL	 	(5)
+#define PG_slab_ORIGINAL	(7)
 #define PG_private_ORIGINAL	(11)	/* Has something at ->private */
 #define PG_swapcache_ORIGINAL	(15)	/* Swap page: swp_entry_t in private */
 
+#define PG_buddy_v2_6_17_to_v2_6_26	(19)
+#define PG_buddy_v2_6_27_to_v2_6_37	(18)
+
+#define PAGE_BUDDY_MAPCOUNT_VALUE_v2_6_38	(-2)
+#define PAGE_BUDDY_MAPCOUNT_VALUE_v2_6_39_to_latest_version	(-128)
+
+#define PAGE_FLAGS_SIZE_v2_6_27_to_latest_version	(4)
+
 #define PAGE_MAPPING_ANON	(1)
 
 #define LSEEKED_BITMAP	(1)




More information about the kexec mailing list