[PATCH 0/3] makedumpfile: calculate the size of cyclic buffer automatically.

Vivek Goyal vgoyal at redhat.com
Fri Nov 9 09:17:17 EST 2012


On Fri, Nov 09, 2012 at 04:02:14PM +0900, Atsushi Kumagai wrote:
> Hello,
> 
> I made the patch set based on v1.5.1-beta to calculate the size of cyclic 
> buffer automatically.
> 
> In v1.5.0, users have to specify the buffer size depending on system memory
> size with --cyclic-buffer option in order to get decent performance.
> 
> This patch set avoids the inconvenience above by choosing the lesser value
> of the two below as the size of cyclic buffer automatically:
> 
>   a. the size enough for storing the 1st/2nd bitmap for the whole of vmcore
>   b. 80% of free memory (as safety limit)
> 
> Additionally, this patch set remove --cyclic-buffer option because I think
> it has been already unnecessary.

I was wondering how about retaining --cyclic-buffer <size> option. If 
there are use cases where user's don't like default of 80% of free memory
they can override this policy by specifying --cyclic-buffer.

Thanks
Vivek



More information about the kexec mailing list