[PATCH makedumpfile v2 0/4] LZO Compression Support

[Atsushi Kumagai]

Hello Hatayama-san,

On Thu, 23 Feb 2012 10:33:54 +0900
HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote:

> The following series implements LZO compression support to
> makedumpfile. LZO is as good as in size but by far better in speed
> than ZLIB, readucing down time during generation of crash dump and
> refiltering.

Sorry for late reply.

[PATCH v2 4/4] allows to use -l option even without USELZO but 
lzo compression doesn't work without USELZO.
I think that warning messages should be displayed when -l option is
used on makedumpfile built without USELZO.

So I made v3 patches attached to this mail.
([PATCH v2 1/4] and [PATCH v2 2/4] look good and I didn't change them.)

  v2 => v3:

     - Add warning messages for invalid -l option.
     - Show LZO support status with help messages.
     - Add description of USELZO in README and man page.
     - (and I will do some cleanups.)

What do you think, Hatayama-san ?


Thanks
Atsushi Kumagai


> The RFC discussion was made here:
> 
>   http://lists.infradead.org/pipermail/kexec/2011-November/005783.html
>   http://lists.infradead.org/pipermail/kexec/2011-December/005868.html
> 
> How to build:
> 
>   1. Get lzo libraries: lzo, lzo-devel and lzo-minilzo from either of
>   the following:
> 
>     1) Original author's website:
>        http://www.oberhumer.com/opensource/lzo/
> 
>     2) yum framework on fedora. Older releases don't have the packages.
> 
>   2. Apply the patch set to makedumpfile v1.4.2.
> 
>   3. Do make as follows:
> 
>     $ make USELZO=on
> 
>     Note: In default, no LZO compression support is included.
> 
> How to use:
> 
>   Introduce new -l option. If a user specify this, makedumpfile
>   generates dumpfile compressed by pages with lzo compression.
> 
>   Example)
>   $ makedumpfile -l vmcore dumpfile
> 
> Performance evaluation:
> 
>   - Kumagai-san's evaluation simulating working servers:
>     http://lists.infradead.org/pipermail/kexec/2011-December/005868.html
> 
>   - My evaluation focusing on the worst cases:
>     http://lists.infradead.org/pipermail/kexec/2011-November/005783.html
> 
> LZO Support for crash:
> 
>   I'll post LZO support patch for crash after makedumpfile merges
>   these patches.
> 
> Changelog:
> 
>   v1 => v2:
> 
>     - Add build condition for LZO support. Enable LZO support if
>       specifying USELZO=on to make command.
> 
>     - Avoid LONG_MAX/ULONG_MAX redefinitions.
> 
> ---
> 
> HATAYAMA Daisuke (4):
>       Add build condition for LZO support
>       Add help and manual messages about LZO compression support
>       Avoid LONG_MAX/ULONG_MAX redefinitions
>       Add LZO Support
> 
> 
>  Makefile       |    5 ++++
>  common.h       |    4 +++
>  diskdump_mod.h |    3 ++-
>  makedumpfile.8 |    6 +++--
>  makedumpfile.c |   67 ++++++++++++++++++++++++++++++++++++++++++++++++++------
>  makedumpfile.h |    4 +++
>  print_info.c   |   16 +++++++------
>  7 files changed, 86 insertions(+), 19 deletions(-)
> 
> -- 
> HATAYAMA Daisuke
> 
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PATCH-v3-3-4-Add-help-and-manual-messages-about-LZO-.patch
Type: application/octet-stream
Size: 4475 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20120323/eb1eff3d/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-PATCH-v3-4-4-Add-build-condition-for-LZO-support.patch
Type: application/octet-stream
Size: 5915 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kexec/attachments/20120323/eb1eff3d/attachment-0003.obj>